search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Shortcode Embeds: add embed_oembed_html filter to all shortcodes #1571

Open RavanH opened 9 years ago

RavanH commented 9 years ago

Hi,

I've noticed that the filter embed_oembed_html can not be counted on because as soon as Jetpack's Shortcode Embeds is activated, this filter is no longer there even if the new shortcode [youtube](or similar) is not used.

Please either add this filter like it was originally implemented in WP core -OR- please do not override the oembed that occurs when simply pasting a Youtube or other media host URL and limit yourself to the [youtube] and similar added shortcodes.

Hope that explanation was not too confusing ;)

Thanks!

ryanburnette commented 7 years ago

I take it from this being on the Not Currently Planned milestone that a fix isn't in the works. Does anyone know a workaround?

jeherve commented 7 years ago

@ryanburnette A work-around would be to programatically disable Jetpack's YouTube handler if you plan on relying on core's implementation only. Here is a little tutorial to walk you through this: https://jetpack.com/2016/05/13/hook-month-customize-modules-shortcodes-widgets/

lamdayap commented 7 years ago

reported here: https://wordpress.org/support/topic/shortcode-embeds-module-should-include-title-attribute-on-iframe-output/#post-9242620

KZeni commented 7 years ago

@ryanburnette I found that simply disabling this module is currently the best way to allow oEmbed filter to be used by themes/plugins without issue (ex. https://wordpress.org/plugins/fluid-video-embeds/ & other plugins.)

nechehin commented 7 years ago

Goto /wp-admin/admin.php?page=jetpack_modules and disable shortcodes module

unitb-ore commented 4 years ago

Goto /wp-admin/admin.php?page=jetpack_modules and disable shortcodes module

Does not work anymore with Jetpack 9.0.x.

unitb-ore commented 4 years ago

I found an alternative solution: https://developer.wordpress.org/reference/hooks/embed_handler_html/

kospl commented 3 years ago

Took a long time trying to debug oembed issue with native WP filters and actions, but none of them seems working when Jetpack enabled.

(and I'm happy I know site uses Jetpack and tried to turn it off, otherwise it could took way too longer to successfully debug WP hooks)