Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 797 forks source link

Sharing buttons: "Customize buttons" unstyled when using AMP Standard #16732

Open laurelfulford opened 4 years ago

laurelfulford commented 4 years ago

Steps to reproduce the issue

  1. On a test site running Twenty Twenty and the latest version of Jetpack (8.8), install and activate the AMP plugin.
  2. Navigate to WP Admin > AMP, and set it to use "Transitional" mode (to make it easier to toggle between the AMP and non-AMP versions of the page).
  3. Enable Sharing buttons on your posts.
  4. View a non-AMP version of a post and note the appearance of the 'Customize buttons' link -- it's been styled to be smaller and a serif font.
  5. Click the "AMP" link in the Admin Toolbar to switch to the AMP version of the post; note the appearance of the 'Customize buttons' link.

What I expected

That the 'Customize buttons' link would appear the same.

What happened instead

The 'Customize buttons' no longer has any special styles, and is picking up the body font size and family.

Screenshots Non-AMP version of the page:

image

AMP version of the page:

image

jeherve commented 4 years ago

Related: #16472

cc @blackjackkent Maybe we should hide that link altogether on AMP views (we can check that with something like class_exists( 'Jetpack_AMP_Support' ) && Jetpack_AMP_Support::is_amp_request())? I'm not sure what's best here.

danjjohnson commented 3 years ago

Just noting that we have had a couple of requests about removing the link entirely:

Currently custom CSS is the only option for that. Would it be worth providing a filter?

jeherve commented 3 years ago

Would it be worth providing a filter?

We can always add in a filter, sure. 👍