search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.57k stars 796 forks source link

Jetpack Carousel + CoBlocks Lightbox conflict #19496

Open RealCarFax opened 3 years ago

RealCarFax commented 3 years ago

Steps to reproduce the issue

Ensure that Jetpack Carousels are enabled and the CoBlocks plugin is installed and active

  1. Create a new page or open an existing page
  2. Insert Gallery block
  3. Add images to Gallery block
  4. On the right, leave lightbox feature disabled
  5. Publish the page, click on an image in the gallery.

What I expected

When Lightbox is disabled, I would expect no lighbox or carousel when you click on the image. Most users don't know the difference between Lightbox and Carousel.

What happened instead

If lightbox is disabled, the Jetpack carousel still shows - this appears to be misleading to our users If lightbox is enabled, a carousel will first show, then when you close out of that the lightbox will show, I don't believe any user would expect that to occur.

It seems the workaround would be to disable the Jetapack carousel feature since this is a whole site setting (you can't turn it on/off for specific gallery blocks) and to toggle on/off the CoBlocks Lightbox feature on each gallery, but this is in no way apparent to our users.

Screenshots Here's a GIF recording I took showing the issue:

https://d.pr/i/VYgTyT/ZKcOwkvn4T

Of note, the lightbox controls were introduced here: https://github.com/godaddy-wordpress/coblocks/pull/1557

If this suggestion is implemented, this would likely help clear things up I think: https://github.com/Automattic/jetpack/issues/15946

ClassicRKR27 commented 2 years ago

Another report here: 33423980-hc

Slack discussion here: p1641331472257800-slack-C03TY6J1A