search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

WPML compatibility: Add configuration for Tiled Gallery Block (and others) #20054

Open kimopreis opened 3 years ago

kimopreis commented 3 years ago

Hi there,

I was asked by the Jetpack support team to create an issue here.

I'm using the Jetpack Tiled Gallery with WPML for translation. In the Advanced Translation Editor of WPML, not all image meta data shows up. WPML advises this:

In regards to Jetpack, please reach out to their support and ask them to assist with a custom XML config for their Block based on this documentation: https://wpml.org/documentation/support/language-configuration-files/#gutenberg-blocks

Full details from my conversation with WPML: https://wpml.org/forums/topic/advanced-translation-editor-images/

Thanks, Kim

jeherve commented 3 years ago

Jetpack already includes a custom XML config file for WPML compatibility: https://github.com/Automattic/jetpack/blob/829ee26a16e5ec36dc7a5310caabb7492d2a6230/projects/plugins/jetpack/wpml-config.xml

That file does not include any info about translating blocks though. This would need to be added (alongside our other blocks).

Partners-OTGS commented 3 years ago

Hi @jeherve ,

Olivia from WPML here. Just checking in to see if you're able to add the remaining blocks to the config file anytime soon? If you need any support from WPML at all, feel free to drop me an email: olivia.oprey@onthegosystems.com.

Cheers! Olivia

jeherve commented 3 years ago

@Partners-OTGS Thanks for reaching out!

I'm not terribly familiar with WPML myself, so we'd definitely appreciate the help!

Our blocks live here: https://github.com/Automattic/jetpack/tree/100413e91fdf4506a58e10d03cb581fc6ac1a740/projects/plugins/jetpack/extensions/blocks

We also have an existing WPML config file, but we haven't added anything to manage blocks.

We'd welcome a Pull Request with an example with one of our blocks, like the Tiled Gallery block, to set the way so others can contribute configurations for other blocks down the road!

Thanks again for reaching out.

Partners-OTGS commented 3 years ago

Sounds like a plan! Give me a week or two while I finish up a few other bits and I'll get it created.

Cheers Jeremy!

On Wed, Aug 18, 2021 at 1:54 PM Jeremy Herve @.***> wrote:

@Partners-OTGS https://github.com/Partners-OTGS Thanks for reaching out!

I'm not terribly familiar with WPML myself, so we'd definitely appreciate the help!

Our blocks live here:

https://github.com/Automattic/jetpack/tree/100413e91fdf4506a58e10d03cb581fc6ac1a740/projects/plugins/jetpack/extensions/blocks

We also have an existing WPML config file https://github.com/Automattic/jetpack/blob/100413e91fdf4506a58e10d03cb581fc6ac1a740/projects/plugins/jetpack/wpml-config.xml, but we haven't added anything to manage blocks.

We'd welcome a Pull Request with an example with one of our blocks, like the Tiled Gallery block, to set the way so others can contribute configurations for other blocks down the road!

Thanks again for reaching out.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Automattic/jetpack/issues/20054#issuecomment-901090083, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATL27DS3MZQTAA5NGPQXCUTT5OUOTANCNFSM46NN6M3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

Partners-OTGS commented 3 years ago

Thanks Jeremy, I've created a PR with a handful of form field blocks added to the config file: https://github.com/Automattic/jetpack/pull/21077.

On Wed, Aug 18, 2021 at 1:54 PM Jeremy Herve @.***> wrote:

@Partners-OTGS https://github.com/Partners-OTGS Thanks for reaching out!

I'm not terribly familiar with WPML myself, so we'd definitely appreciate the help!

Our blocks live here:

https://github.com/Automattic/jetpack/tree/100413e91fdf4506a58e10d03cb581fc6ac1a740/projects/plugins/jetpack/extensions/blocks

We also have an existing WPML config file https://github.com/Automattic/jetpack/blob/100413e91fdf4506a58e10d03cb581fc6ac1a740/projects/plugins/jetpack/wpml-config.xml, but we haven't added anything to manage blocks.

We'd welcome a Pull Request with an example with one of our blocks, like the Tiled Gallery block, to set the way so others can contribute configurations for other blocks down the road!

Thanks again for reaching out.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Automattic/jetpack/issues/20054#issuecomment-901090083, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATL27DS3MZQTAA5NGPQXCUTT5OUOTANCNFSM46NN6M3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .