Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 799 forks source link

Tiled Gallery linked images are restricted in size smaller than the original #21194

Open ACEkin opened 2 years ago

ACEkin commented 2 years ago

Impacted plugin

Jetpack

Steps to Reproduce

Upload images 1600 px wide Using them, create a tiled gallery Display the post, and click on a thumbnail Observe the displayed image size which will be limited to a smaller size

There is a support post that with more examples. https://wordpress.org/support/topic/tiled-gallery-image-size-problem/

But, here are some relevant links:

This is where the problem can be seen: https://www.testbed.biz/tiled-gallery-image-dimension-problem/

The images should display 1600 px wide

These two posts were manually fixed in the code editor, the file suffix _750x500 or _1024x768 were removed in the process. The clicked target images started displaying correctly: https://www.keptlight.com/pawtuxet-village-in-infrared/ https://www.keptlight.com/larry-dunn-exhibit/

In the following post, there is a corrected tiled gallery followed by a new one I inserted a couple of days ago to demonstrate the problem. In the original post, published on Sept 4, 2021, there was no problem with any of the tiled galleries. The newly inserted one displays the clicked images smaller than they should be. Scroll down until you see the duplicate gallery. The first will function fine as it was created on the day of the publishing but the second one will manifest the problem. https://www.keptlight.com/lightroom-local-adjustments-for-midtone-control/

On the KeptLight.com site, the theme has not changed for quite a while. It is Genesis Framework child theme called Mai Success by https://bizbudding.com/ The plugin engine was updated on 9/16/2921 which is two days after I started observing the problem on 9/14/2021 as I published the exhibit announcement post which manifested the problem for me for the first time. Jetpack was updated on 9/7/2021 which makes it the prime suspect! I rest my case! ;-)

A clear and concise description of what you expected to happen.

I expected the displayed target images to be full size, 1600px wide screen width permitting.

What actually happened

The target images displayed were considerably smaller and the file names all had a suffix added as explained above.

Other information

No response

Operating System

Windows 10

OS Version

Latest available update

Browser

Firefox, Microsoft Edge

Browser Version(s)

92.0 and 94.0.992.31

jeherve commented 2 years ago

Thanks for the report!

Related: #19445, #18636

ACEkin commented 2 years ago

Update after Jetpack 10.2

On the following link is a short post as before, it displays a broken TG followed by a new gallery created right after updating Jetpack to 10.2, and the second gallery displays as expected:

https://www.testbed.biz/tiled-gallery-image-dimension-problem/

The second gallery was created after updating the plugin to 10.2 on 10/5/2021 and it seemed to work as expected. I made one change in the workflow and uploaded the images through the Tiled Gallery upload button. They are in a different folder from the first one but otherwise identical images.

Thinking that uploading through Tiled Gallery may be a solution and created a similar gallery on KeptLight.com but that still showed the problem of the wrong size of the image displayed in the lightbox.

ACEkin commented 2 years ago

Will these bugs ever be fixed or is it time for some of us to find other solutions? New features are being added but the old bug reports seem to get ignored. I reported a bug with the square tiles displaying the square images upon clicking on the thumbnail although the full-size image may be landscape or portrait orientation more than a year ago. As of now, that bug is still not fixed. The one reported on this ticket is still a problem. Eroding trust is a much bigger bug.

jeherve commented 2 years ago

@ACEkin I understand your frustration. We're not currently working on the Tiled Gallery block, but we will be making some changes to the block in the future, to better work with the recent changes to the Gallery Block in WordPress itself (see https://github.com/WordPress/gutenberg/pull/25940 ).

Ideally, we'd like to make changes to Jetpack's implementation so it is closer to how native galleries work. In the process, we can expect issues like the ones you've reported to get solved.

We'll update this issue as soon as we make progress on this!

ACEkin commented 2 years ago

@jeherve thank you for the reply and update. All is good, but from a user viewpoint, when a working feature breaks, like the latest tiled gallery image size issue, and the sites suffer. At least my site is suffering and I am manually fixing all the old Tiled Gallery blocks. I may end up switching them all to NextGEN Galleries. I don't want to debate the issue here but when a working feature breaks it should get priority treatment. But, there is far more attention given, it seems, to adding new features to a product I once predicted to swallow WordPress. Jetpack is getting far too big and complex for its own good and those of us who have been using it and some of its features are feeling the pinch. Or the punch!

I am writing these comments with the best of intentions of helping to improve your product, not just to argue a point. Please consider the strategic vision of Jetpack and see if it needs reevaluation.

ACEkin commented 2 years ago

I would like to offer another piece of information with the hopes that it may help with the solution. After the latest JtPack update today, 1/11/22, I tried creating a post with a tiled gallery on my staging site. It worked fine. That site has just one post, Hello World. Hoping that the problem might be fixed, I tried a new post on my regular site. No dice! After that, I tried the following:

  1. Switched to the Classic Editor
  2. Inserted a Tiled Gallery there, it worked fine. The image sizes were as expected
  3. I switched back to the Block Editor and added a new tiled gallery using the same images
  4. That one inserted in the block editor displays smaller size images when clicked on while the gallery inserted in the classic editor displays larger images.
  5. You can see the test post with this odd behavior in the test post Don't let the date confuse you, I pushed it way back so as not to clutter the recent content. https://www.keptlight.com/test/

The displayed image size problem seems to stem from the block editor. The one inserted in the classic editor simply shows as embed code, its simplicity is striking:

[gallery type="rectangular" link="file" ids="43422,43421,43420,43419,43319"]

I wonder if this information may help? Currently, I am either avoiding Tiled Gallery or very tediously editing the code the remove the size suffixes from the image file names.

Cemal

pasta-farian commented 1 year ago

Got bitten by this bug too. Thanks ACEkin for reporting the problem and the (tedious) workaround.