search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 799 forks source link

Tiled Gallery Block: compatibility with the Gallery Custom Links Plugin #21476

Open Skyrals opened 2 years ago

Skyrals commented 2 years ago

Impacted plugin

Jetpack

Steps to Reproduce

Install Gallery Custom Links Plugin by Jordy Meow and activate it

Create a page with a Jetpack tiled mosaic gallery on it using different sized images

A clear and concise description of what you expected to happen.

Gallery should correctly resize images to fit each tile

What actually happened

There are visible gaps between tiles as images are not resized correctly to fit tile

Other information

The CSS is incorrect, this additional CSS override will fix it:

.tiled-galleryitem > a, .tiled-galleryitem > a > img, .tiled-gallery__item > img { height: 100% !important; }

Operating System

Windows

OS Version

Windows 10

Browser

Chrome/Chromium

Browser Version(s)

latest

jeherve commented 2 years ago

Thanks for the report.

Related: WordPress Core will start supporting links for gallery images in the next major version of WordPress, thanks to this change https://github.com/WordPress/gutenberg/pull/25940 This should allow Jetpack's Tiled Gallery Block to benefit from that change and support custom links too: https://github.com/Automattic/jetpack/issues/13760