search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 799 forks source link

Blocks: use JetpackLogo from Jetpack components #22730

Open jeherve opened 2 years ago

jeherve commented 2 years ago

The block bundle in the Jetpack plugin has a JetpackLogo that is used to render the Jetpack logo in multiple places: https://github.com/Automattic/jetpack/blob/94bc84fd2dd774b8237c995d67decd5a323d8a3d/projects/plugins/jetpack/extensions/shared/icons.js#L187

This works fine, but we now have a JetpackLogo in use in projects leveraging RNA: https://github.com/Automattic/jetpack/blob/3238c5d6df6727ce64fc18763a0025f10920a317/projects/js-packages/components/components/jetpack-logo/index.jsx#L13

It would be nice if the block bundle could use that instead.

jeherve commented 2 years ago

I should note, however, that while the block bundle inside the Jetpack plugin relies on @wordpress/element and @wordpress/components, the RNA components do not, and rely on React directly. @oskosk Do you think that's something that may change in the future, so it makes even more sense to use RNA components in WordPress interfaces?