My Jetpack: Handle manually install for plugins

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.

https://jetpack.com/

Other

1.58k stars 799 forks source link

My Jetpack: Handle manually install for plugins #22982

Open renatoagds opened 2 years ago

renatoagds commented 2 years ago

When site does not have write access to the filesystem, we should prompt the user to download the plugin and install it by themselves.

Free Plugins

Paid Plugins

westonruter commented 6 months ago

It seems like this has regressed. I just tested on my site with a readonly filesystem.

First I see this:

I click "Learn More" and am taken to:

I then click "Start for Free" and am taken to /wp-admin/admin.php?page=jetpack-boost and am presented with:

I get a similar experience when attempting to activate the CRM feature.

renatoagds commented 6 months ago

@Automattic/jetpack-martech can you take a look at this one?

CodeyGuyDylan commented 6 months ago

@Automattic/jetpack-martech can you take a look at this one?

Taking a look now, possible this was introduced with the redux to tanstack migration

CodeyGuyDylan commented 6 months ago

Ah I see what happened. Boost used to use the ProductDetailCard component, but now it uses the ProductDetailTable to show the paid and free plan. The solution was only implemented in the ProductDetailCard component and so this still works correctly on products that use it, it never worked (as far as I can tell) on products that use the table. I've added this as an issue to our maintenance board and it will get prioritized Monday (March 18)

westonruter commented 6 months ago

Just to be clear, it happened to me when activating Boost as well as CRM. I didn't try other features.

CodeyGuyDylan commented 6 months ago

Interesting, when I go to CRM when write access is disabled, I see this and I can't click on the CTA

westonruter commented 6 months ago

When I try to install CRM, I can click that button and I am taken to /wp-admin/admin.php?page=zerobscrm-plugin but with a wp_die() error message:

Sorry, you are not allowed to access this page.

renatoagds commented 6 months ago

I'll reopen the issue and assignee it for you @CodeyGuyDylan so we don't lost it

CodeyGuyDylan commented 6 months ago

When I try to install CRM, I can click that button and I am taken to /wp-admin/admin.php?page=zerobscrm-plugin but with a wp_die() error message:

Sorry, you are not allowed to access this page.

Strange, I am unable to reproduce this error, whoever picks up this maintenance task will look into it further 😄

I'll reopen the issue and assignee it for you @CodeyGuyDylan so we don't lost it

Sounds good, I've also added it to my teams Maintenance board so it shouldn't get lost there

westonruter commented 6 months ago

When I try to install CRM, I can click that button and I am taken to /wp-admin/admin.php?page=zerobscrm-plugin but with a wp_die() error message:

Sorry, you are not allowed to access this page.

Strange, I am unable to reproduce this error, whoever picks up this maintenance task will look into it further 😄

FWIW, I experienced this on a live environment on Pantheon.