Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 797 forks source link

Recipes Block: Primary issue #24632

Open jeherve opened 2 years ago

jeherve commented 2 years ago

This issue lists the remaining items to address before the recipe block introduced in #24343 can be launched.


Internal references:

Previous references:

jeherve commented 2 years ago

@that-mike-bal Feel free to edit the issue above and add to the list if you have more items you'd like to address.

that-mike-bal commented 2 years ago

Hey @jeherve - where would the keywords go? I'm happy to write those up.

jeherve commented 2 years ago

@that-mike-bal Keywords are added here: https://github.com/Automattic/jetpack/blob/9c9687a314168185133e50d11cd2bcef84fc5239/projects/plugins/jetpack/extensions/blocks/recipe/index.js#L38

that-mike-bal commented 2 years ago

Hey @magnificode - here are some keywords I think cover the basic/most common uses.

recipes, recipe block, recipe patterns, cooking instructions, ingredients, baking instructions, cooking, food

magnificode commented 2 years ago

Hey @that-mike-bal @jeherve and @kraftbj -

24904 should handle a few of the items above, specifically the following:

I spoke with Mike, and I believe the remaining tasks within this issue may be better suited for an a8c team member to handle. Specifically the block tests. I've not written Jest or PHP Unit tests myself before, and would be concerned about the quality of those tests if I wrote them using contextual knowledge from other blocks. I'm more than happy to pair with an a8c team member who has experience writing these tests if that would be helpful! I'd just hate to write sub-par tests myself 😬 .

Let me know if this satisfies those few parameters above that I mentioned. Happy to discuss anything else further if necessary!

supernovia commented 2 years ago

Hi! I just happened across this block. I'm excited! And I have a few issues.

  1. I was testing to see if this would import into recipe apps. Can we add hrecipe or Recipe microdata to this?

  2. The print recipe button printed the blog post, my logo, weird headers at the top of each page and what not... I think if we get the microdata in place, we can use that to make a recipe-friendly print style.