WhatsApp Block: issues when removing child button block

nagpai commented 2 years ago

Quick summary

The WhatsApp button block creates a send message block with a WhatsApp button block nested within it.

When a user tries to delete the block it reappears on reload of editor. Because of the UI of gutenberg, users typically end up deleting the Button block and not the parent send message block that remains invisible. The whatsapp button gets added again

Steps to reproduce

Create a new page or post
Add WhatsApp block and save changes.
Reload browser, and click and delete the whatsapp button. It removes the button. Save changes. There is no indication of the parent Send a message block being still active.
Reload the browser, the button reappears.

Uploading whatsapp-bug.mov…

What you expected to happen

Ideal case - The parent Send a message block should get deleted when someone deletes the whatsapp button.

Next-to-ideal : Show a dummy block in editor that the Send message block is still present.

What actually happened

Described in the video and details above.

Context

36020401-hc

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

No response

Browser, operating system and other notes

MacOS - Vivaldi 5.3.2679.68

( happens across different browsers though )

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, difficult to implement

Workaround details

Use the list view and delete the parent Send a message block

Robertght commented 2 years ago

📌 HOUSEKEEPING

Labels ✅
Priority ✅
Replicable on Core - Yes

📌 SCRUBBING

Tested on P2 - no
Tested on Simple ✅
Tested on AT ✅
Tested on Self-hosted ✅

📌 FINDINGS/SCREENSHOTS/VIDEO

I can replicate it as well, however, I believe this is the same: https://github.com/Automattic/jetpack/issues/18104 cc @jeherve for a second look.

Using the List view should help the users remove that block entirely.

📌 ACTIONS

Marked as Triaged for Quality Squad review
Transferred to XYZ external repo: link

📌 Message to Author

The video didn't upload, however, you can upload it here later if you want.

github-actions[bot] commented 2 years ago

Support References

[ ] 36020401-hc
[ ] 8226220-hc

jeherve commented 2 years ago

Yup, that's the same issue indeed. I'll close the other one since there are more details here.

jeherve commented 2 years ago

Related: #24838

Additional info from #18104:

References:

8226220-hc

this happens because you're deleting the child block, and not the parent block. Here is how I would go about it:

videopress.com/v/pYqlck4o

That's an annoying byproduct of parent / child blocks.

Automattic / jetpack