search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 797 forks source link

Slideshow Block: Pagination added in 11.7 beta doesn't work with AMP #28210

Open laurelfulford opened 1 year ago

laurelfulford commented 1 year ago

Impacted plugin

Jetpack

Steps to Reproduce

  1. Start with a site running the 11.7 beta.
  2. Install and activate the AMP plugin.
  3. Add one or more slideshow blocks to a post or page; for each block, add six images.
  4. View the AMP version of the page on the front-end.

A clear and concise description of what you expected to happen.

I expected the updated pagination to continue to be AMP (things like the slideshow advancing still work as expected with AMP!).

What actually happened

The pagination doesn't update as you page through the photos.

Also, if you have more than one slideshow on the page, the pagination starts at an offset number (1/6 for the first one, 2/6 for the second one...).

Lastly, the slideshow has some very minor display issues when AMP is enabled (like the previous/next buttons are a lot closer to the edge).

Browser

Google Chrome/Chromium, Mozilla Firefox, Apple Safari

Other information

Slideshow without AMP:

Screen Shot 2023-01-06 at 11 39 29 AM

Slideshow with AMP:

Screen Shot 2023-01-06 at 11 39 21 AM

Platform (Simple, Atomic, or both?)

Atomic, Self-hosted

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, easy to implement

Workaround details

Disabling AMP on a per post/page basis fixes the issue, but as it does impact existing slideshows they would need to be found on a site using AMP and have AMP disabled on those pages.

coder-karen commented 1 year ago

Pagination was implemented here - https://github.com/Automattic/jetpack/pull/27936 - cc @retrofox

github-actions[bot] commented 1 year ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.