Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 799 forks source link

Jetpack: Deleting Jetpack plugin breaks the Jetpack connection on standalone plugins #28540

Open dhasilva opened 1 year ago

dhasilva commented 1 year ago

Steps to reproduce:

1 - With Jetpack and VideoPress installed, connect the site 2 - Deactivate and delete the Jetpack plugin 3 - Check that the connection is broken, even though we still have the VideoPress plugin installed

p1674497316761689/1674497281.387129-slack-C03TA48NSUX

PS: This could potentially be happening to other plugins as well

nunyvega commented 1 year ago

Not specific to VideoPress: I tested it on a site with VaultPress Backup active and connected and Jetpack installed but deactivated, when I delete Jetpack it disconnects the Backup plugin too.

jeherve commented 1 year ago

I believe @leogermani could tell you more about this, but I think this may be done on purpose.

For reference, here are some past discussions about this:

leogermani commented 1 year ago

If I recall correctly this was the behavior before https://github.com/Automattic/jetpack/pull/23957/files

So the expected behavior now was for the connection to be kept alive if other plugins are using it. So it may be a regression.

cc @sergeymitr who followed this closely as well.

jeherve commented 1 year ago

This was also reported in #30243, for WooCommerce Payments