Open jorekai opened 1 year ago
There seems to be an issue with the fullscreen toggle in the latest videopress version. The built does not get the correct fullscreen attributes. This issue might originate from this line of code:</p> <p><a rel="noreferrer nofollow" target="_blank" href="https://github.com/Automattic/jetpack/blob/666d612b1bef125096cdbf90125ce04a72be49a5/projects/packages/videopress/src/class-block-editor-content.php#L121">https://github.com/Automattic/jetpack/blob/666d612b1bef125096cdbf90125ce04a72be49a5/projects/packages/videopress/src/class-block-editor-content.php#L121</a></p> <p>When using the Gutenberg Videopress Embed Blog in Production I cannot toggle fullscreen. When using it inside of The Gutenberg Blocker Editor mode i can toggle it succesfully</p> <p><img referrerpolicy="no-referrer" src="https://user-images.githubusercontent.com/15143394/214934963-e22f48af-a5f2-4016-9dc7-0d8a3898b2ff.png" alt="image" /></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jeherve"><img src="https://avatars.githubusercontent.com/u/426388?v=4" />jeherve</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Thank you for the report!</p> <p>@dhasilva Do you think you could take a look?</p> <p>Thanks!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dhasilva"><img src="https://avatars.githubusercontent.com/u/8486249?v=4" />dhasilva</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>I'm not able to reproduce the issue here with the latest Jetpack and VideoPress plugins. There was <a href="https://github.com/Automattic/jetpack/pull/28342">a PR</a> solving this issue in the Jetpack plugin.</p> <p>Are you using the VideoPress plugin, Jetpack or both? And which versions, please?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/jorekai"><img src="https://avatars.githubusercontent.com/u/15143394?v=4" />jorekai</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Hey thanks for looking into it, I'm just using Jetpack VideoPress @ V1.3.0. Below is the generated iframe element on my page.</p> <pre><code class="language-html"><iframe data-placeholder-image="****" data-category="marketing" data-service="videopress" class="cmplz-placeholder-element cmplz-no-video cmplz-processed cmplz-activated" data-cmplz-target="src" data-src-cmplz="https://videopress.com/embed/*****?cover=1&amp;preloadContent=metadata&amp;useAverageColor=1&amp;hd=1" title="VideoPress Video Player" aria-label="VideoPress Video Player" width="710.075" height="399.772225" src="https://videopress.com/embed/****?cover=1&amp;preloadContent=metadata&amp;useAverageColor=1&amp;hd=1" true"="" allow="clipboard-write"></iframe></code></pre> <p>There is also no allowfullscreen property here:</p> <p><img src="https://user-images.githubusercontent.com/15143394/215264821-e9a090d8-9354-4135-b8f5-7f4dc968ad74.png" alt="image" /></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dhasilva"><img src="https://avatars.githubusercontent.com/u/8486249?v=4" />dhasilva</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Testing VideoPress 1.3.0 without Jetpack installed and I still can't reproduce the problem.</p> <p>What block are you using?</p> <p>The VideoPress block: <img src="https://user-images.githubusercontent.com/8486249/215563163-334d9f9b-6787-467f-b745-aa1d62289f0b.png" alt="2023-01-30_15-24-09" /></p> <p>The shortcode block: <img src="https://user-images.githubusercontent.com/8486249/215563217-46e8b922-62cf-48e3-ba28-64153a68728c.png" alt="2023-01-30_15-24-50" /></p> <p>Or the embed block? <img src="https://user-images.githubusercontent.com/8486249/215563259-ffcd72b1-ecbf-4a68-8de6-1a072653b866.png" alt="2023-01-30_15-25-06" /></p> <p>Also, which browser and OS are you using?</p> <hr /> <p>The provided generated iframe seems to be the one from the VideoPress block and indeed it has a problem, but the code line you linked to is used in the shortcode exclusively, not in the VideoPress block, so the issue is probably somewhere else. That is why we need to narrow down the possibilities.</p> <p>I also noticed some injected classes in the iframe that seems to be from the Complianz plugin, is that right? I tried installing this plugin here to see if there is some interference at play, but I still couldn't reproduce the issue, though the classes (like <code>cmplz-placeholder-element</code>) are not injected here, so maybe it needs some aditional configuration. Can you test if there is any change by disabling the Complianz plugin, please?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/github-actions[bot]"><img src="https://avatars.githubusercontent.com/in/15368?v=4" />github-actions[bot]</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>This issue has been marked as stale. This happened because:</p> <ul> <li>It has been inactive for the past 6 months.</li> <li>It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `Good For Community`, `[Type] Good First Bug`, etc.</li> </ul> <p>No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
There seems to be an issue with the fullscreen toggle in the latest videopress version. The built