Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 796 forks source link

[Block] Form - Date picker title header (month, year, arrows) inherits theme foreground color, making it unreadable on dark themes #29793

Open radtechgh opened 1 year ago

radtechgh commented 1 year ago

Quick summary

User added a Form block, used date picker. On live view, the calendar shows the day numbers, but not the month, year, or prev/next arrows.

Steps to reproduce

  1. Form with date picker field added to page.
  2. Publish page.
  3. View page, select date picker, title header appears blank.
  4. Switch to another FSE theme (Zoologist in my test), form date picker now shows the proper calendar with titles.

What you expected to happen

Date picker should show the month, year and previous/next arrows. Plus day date numbers.

What actually happened

Entire title area of date picker is blank.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

CSS (provided by another HE) will add the month and year back, but not the prev/next arrows:

div#ui-datepicker-div {
    color: #333;
}
radtechgh commented 1 year ago

initial site: 6067936-zen

github-actions[bot] commented 1 year ago

Support References

This comment is automatically generated. Please do not edit it.

cuemarie commented 1 year ago

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO

body {
  color: var(--wp--custom--color--foreground);

AT Example Markup on 2023-03-29 at 17:48:32

Simple Example

Markup on 2023-03-29 at 17:43:12

Screen Capture on 2023-03-29 at 17-44-06

📌 ACTIONS

github-actions[bot] commented 10 months ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

anomiex commented 9 months ago

Issue is still present.

If nothing else, probably https://github.com/Automattic/jetpack/blob/trunk/projects/packages/forms/src/contact-form/css/jquery-ui-datepicker.css should do more overriding of styles if it's not going to try to use theme variables.

Gustavo-Hilario commented 5 months ago

Another report here: 7720615-zen

cuemarie commented 5 months ago

Encountered this here on a light theme as well: 7627294-zen

Example: (Content highlighted so you can see it, but its white text on white bg):

CleanShot 2024-02-12 at 10 55 19@2x

Provided CSS to resolve the issue.

#ui-datepicker-div {
    color: #000;
}
upwardmomentum84 commented 2 months ago

Reported here: 8022733-zd-a8c

Provided CSS to resolve issue.