Open SiobhyB opened 1 year ago
π SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain
π FINDINGS/SCREENSHOTS/VIDEO Tested in an AT WPcom site, and here's what reset and what did not in the block settings:
Settings before replacing video:
Settings after replacing video:
π ACTIONS
This issue has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore β if you do, please add a brief explanation.
Impacted plugin
VideoPress
Quick summary
When you replace a video in a block some of the block's saved settings are not retained, while some are not.
Steps to reproduce
A clear and concise description of what you expected to happen.
I would expect for either all of the block's setting to be retained or for all of the them to be 'reset' following the replacement. As other media block's generally retain settings when there's a replacement, I would lean more towards settings being retained as an expectation.
What actually happened
The only settings that are not retained at the block's description and any changes made under the Privacy and Ratings panel. Change to the title and playback settings are retained.
https://user-images.githubusercontent.com/2998162/233494443-cb58129b-b80f-44a4-aff0-c36c678b7ff8.mov
A proposal to retain all settings in the app has been made in https://github.com/Automattic/jetpack/pull/30229, but it is on hold so that we can align with the web's handling of this. If we decide that all settings should be retained following a replacement, please ping me on that PR so that both the web and the app align on this.
Impact
One
Available workarounds?
No and the platform is unusable
Platform (Simple and/or Atomic)
No response
Logs or notes
No response