Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 799 forks source link

Carousel & Tiled Gallery module interfering with Elementor Basic Gallery #31137

Open gaurav1984 opened 1 year ago

gaurav1984 commented 1 year ago

Impacted plugin

Jetpack

Quick summary

Jetpack adds / changes some code for Elementor Basic Gallery widget if the Tiled Galleries or Carousel modules are active.

Steps to reproduce

  1. Install Jetpack, Elementor and Hello Elementor theme on a fresh install of WordPress
  2. Create a new page or post using Elementor editor,
  3. Add Basic Gallery widget with a few images to the page
  4. Preview the page and check/inspect the code for the Basic Gallery widget

A clear and concise description of what you expected to happen.

If Carousel & Tiled Gallery modules are deactivated, the code for the Basic Gallery widget shows

Elementor Gallery works file 

<div class="elementor-image-gallery">
    <div id="gallery-1" class="gallery galleryid-231 gallery-columns-4 gallery-size-thumbnail"><figure class="gallery-item">
        <div class="gallery-icon landscape">

What actually happened

If Carousell module is active code for the Basic Gallery widget shows

<div class="elementor-image-gallery">
    <div data-carousel-extra="{"blog_id":1,"permalink":"https:\/\/example.com\/page-231\/"}" id="gallery-1" class="gallery galleryid-231 gallery-columns-4 gallery-size-thumbnail"><figure class="gallery-item">
        <div class="gallery-icon landscape">

The following meta information was added

data-carousel-extra="{"blog_id":1,"permalink":"https:\/\/example.com\/page-231\/"}"


If Tiled Galleries module is active code for the Basic Gallery widget gets changed to

<div class="elementor-image-gallery">
    <div class="tiled-gallery type-rectangular" data-original-width="800" data-carousel-extra="null" itemscope="" itemtype="http://schema.org/ImageGallery"> 
        <div class="gallery-row" style="width: 800px; height: 382px;" data-original-width="800" data-original-height="382"> <div class="gallery-group images-2" style="width: 340px; height: 382px;" data-original-width="340" data-original-height="382"> 
            <div class="tiled-gallery-item tiled-gallery-item-large" itemprop="associatedMedia" itemscope="" itemtype="http://schema.org/ImageObject"> 

Impact

One

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic, Self-hosted

Logs or notes

Issue reported here wordpress.org/support/topic/jetpack-breaks-elementor-basic-gallery

Tested with

github-actions[bot] commented 11 months ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.