Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Ad block: block toolbar menu items under 'Change format' have the role 'menuitemcheckbox' instead of 'menuitem'. #32703

Open worldomonation opened 1 year ago

worldomonation commented 1 year ago

Impacted plugin

Jetpack

Quick summary

The 'Change format' popover menu items for the Ad block have the 'menuitemcheckbox' role instead of the expected 'menuitem'.

WAI-ARIA explains the 'menuitemcheckbox' as supporting multiple states, but as far as I can tell, this functionality is not used in the current implementation of the Ad block.

Steps to reproduce

  1. enable Jetpack Earn if required (Sidebar -> Jetpack -> Settings (on top right) -> Earn -> Toggle on)
  2. start a new post.
  3. insert the Ad block.
  4. select the block if required.
  5. on the editor toolbar, click on the "Change format" button.
  6. inspect accessibility settings in the toolbar.

Screenshot 2023-08-28 at 2 54 33 PM

A clear and concise description of what you expected to happen.

The popover menu items should have the 'menuitem' role, like with every other block we've seen so far.

What actually happened

The popover menu has the role 'menuitemcheckbox'.

Screenshot 2023-08-28 at 2 54 04 PM

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Atomic

Logs or notes

No response

worldomonation commented 1 year ago

It shouldn't be escalated, it's a bug without a workaround but the issue is more on the accessibility side and the impact is small.

github-actions[bot] commented 8 months ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.