Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 799 forks source link

Form: Forms Display Bullets Instead of Checkbox/Radio Options in Editor #33301

Open karenroldan opened 11 months ago

karenroldan commented 11 months ago

Impacted plugin

Jetpack

Quick summary

When editing a form in Jetpack that contains multiple-choice (checkbox) or single-choice (radio) options, the options are incorrectly displayed as bullets in the editor. This visual inconsistency might lead users to think their checkboxes or radio buttons were changed.

Note that the live post/page still renders the checkboxes or radio buttons correctly.

This issue was found as part of Jetpack Testing p8oabR-1ml-p2.

Steps to reproduce

  1. In a new or existing post, add a form.
  2. Add a multiple-choice or single-choice field.
  3. Save and view the post.
  4. Edit the post again.
  5. Observe that the options are rendered as bullets.

9yrCHV.png

A clear and concise description of what you expected to happen.

The checkbox or radio options should retain their respective displays within the editor.

What actually happened

Options appear as bullet points in the editor but render correctly when the page is viewed. If I reselect the form in the editor, it updates and displays the checkboxes and radio buttons.

https://github.com/Automattic/jetpack/assets/67279475/7b4068c1-1670-4ca4-85da-876226369dac

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

No response

cuemarie commented 11 months ago

📌 REPRODUCTION RESULTS

📌 FINDINGS/SCREENSHOTS/VIDEO I could replicate this the clearest on my AT site after saving the post, then editing the template and returning to the post editor, as shown here:

https://github.com/Automattic/jetpack/assets/27249804/5f200658-de8a-465a-aa73-4f0545f52ad9

On Simple and Self-Hosted, I never got stuck with just the bullet points showing, but I can see them load before the Checkboxes/Radio buttons appear, so it's possible the same issue could occur there with more testing.

📌 ACTIONS

github-actions[bot] commented 5 months ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

monsieur-z commented 4 months ago

I'm able to reproduce the issue consistently in any environment by switching between device previews.

Screenshot 2024-05-08 at 3 23 42 PM