search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 799 forks source link

Search.php still loads in the background before the Jetpack Search modal loads #33704

Open kimclowa8c opened 12 months ago

kimclowa8c commented 12 months ago

Impacted plugin

Jetpack, Search

What

When using a Productivity App - search.php loads in the background before the Jetpack Search modal loads

How

Sometimes when you have JP Search enabled on the site, the search.php file loads in the background while you wait for the JP Search modal to pop up. This is especially evident when using a Productivity App (like Alfred).

As this page isn't always styled, it would be great if this didn't happen. It would be better to have a blank page, than an un-styled one.

Here's a screen recording showing (what I think is) search.php before the Jetpack Search Modal displays.

https://github.com/Automattic/jetpack/assets/426388/6b44aa34-e9e7-4e5c-8b0d-a79d9f503280

Is it possible to change this, so if JP Search is enabled, the Search.php file doesn't ever load?

anomiex commented 12 months ago

It would be better to have a blank page, than an un-styled one.

On the other hand, if the user's browser can't support the Instant Search popup (e.g. it's too old or JavaScript is off) then it would be nice if they still get a fallback search form rather than a blank page.

kimclowa8c commented 11 months ago

Hey @anomiex - yeah, definitely something to factor in! If the modal can't be supported and the user is served search.php - that bypasses Jetpack Search altogether doesn't it? I'm not sure of this answer.

If the browser can support the modal, it would be good to avoid the unstyled page.