Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 800 forks source link

Bug: Delete cache button does not trigger wpsc_after_delete_cache_admin_bar hook when used from admin panel #34637

Open Dalias96 opened 8 months ago

Dalias96 commented 8 months ago

Impacted plugin

Super Cache

Quick summary

When deleting cache via button on admin panel side, hook wpsc_after_delete_cache_admin_bar is not triggered, as function is called via AJAX call.

Steps to reproduce

  1. Add any action to wpsc_after_delete_cache_admin_bar
  2. Run cache delete from front site, hook will trigger properly
  3. Run cache delete from admin panel
  4. Hook will not fire

A clear and concise description of what you expected to happen.

In that case, hook should be fired with path / as cache is purged for entire page then.

What actually happened

No response

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

Dalias96 commented 8 months ago

I created possible fix for that its there https://github.com/Automattic/jetpack/pull/34638

github-actions[bot] commented 2 months ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.