Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 798 forks source link

[Boost] Move styles into module stylesheets #35010

Open thingalon opened 7 months ago

thingalon commented 7 months ago

Note: this is a fiddly task with lots of little bits. I recommend against trying to tackle it in one giant PR. Make small quick PRs over time. Another note: this is not a blocker to release.

We have styles spread across global CSS files and module files. We've decided that moving forward module files are the way to go for all but the most global-of-global things.

Here are some examples of things that can be moved into module styles:

But there are more.

### Tasks
- [ ] https://github.com/Automattic/jetpack/pull/35156
- [ ] https://github.com/Automattic/jetpack/pull/35516
- [ ] components/isa (part 2)
- [ ] components/button
- [ ] components/snackbar
haqadn commented 7 months ago

I am attempting this in #35104. However, the ISA styles are too tangled to modularize without risking UI bugs.

thingalon commented 7 months ago

I am attempting this in #35104. However, the ISA styles are too tangled to modularize without risking UI bugs.

Don't feel pressure to solve 100% of all cases in one go. It's ok for this to take multiple smaller PRs, and it's ok to enlist help from @pyronaur (who built the IG UI) to sort out some of the tricker cases.

dilirity commented 6 months ago

I'm splitting moving ISA components into two parts, as the first PR has gotten quite big. Moving some of the styles would require more work.