Subscription popup looks bad on Bedrock theme

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.

https://jetpack.com/

Other

1.58k stars 799 forks source link

Subscription popup looks bad on Bedrock theme #35413

Open pkuliga opened 7 months ago

pkuliga commented 7 months ago

To reproduce

Enable the Subscription popup from the Newsletter Settings
Use the Bedrock theme
Open the post and scroll down to open the popup
Notice that the text above the input is invisible

Expected result

The text above the input is visible.

rickmgithub commented 7 months ago

📌 REPRODUCTION RESULTS

Tested on Simple – Replicated
Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

Exactly as the OP said. There is a workaround and that is to edit the popup button to give it black letters but as the view in the editor then show black letters on a black background while the popup is white, it's confusing for users.

📌 ACTIONS

Triaged

bizanimesh commented 7 months ago

👋 I can reproduce the issue (screenshot) - I see because of white color the text is not visible. But this can be modified from the theme editor.

@pkuliga - have you tried editing the pop-up block? You can go to your WordPress.com dashboard and change the color of the texts like this (as a workaround):

https://github.com/Automattic/jetpack/assets/52444539/e07796ed-0dcf-49e0-8c80-f60bf773b574

pkuliga commented 7 months ago

@bizanimesh yup, I know I can edit the template but shouldn't the text be visible by default?

Modal already inherits some of the theme styles, like text color, but the background is always white. That's why we have a problem.

I think we need to either inherit the theme background color as well, if possible, to make the text readable or to not inherit the text color and define our own that will be readable on a white background.

bizanimesh commented 7 months ago

Hello @pkuliga - yes, the team will take a look. In the meantime, you may apply the workaround. :)

github-actions[bot] commented 1 month ago

This issue has been marked as stale. This happened because:

It has been inactive for the past 6 months.
It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `[Type] Janitorial`, `Good For Community`, `[Type] Good First Bug`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.