search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Featured Content Front page vs Posts page ambiguity #3650

Open richardmtl opened 8 years ago

richardmtl commented 8 years ago

This came up in 2611402-t.

Normally when the "Display tag content in all listings" option is unchecked in the Customizer, it removes any posts from the frontpage feed that is tagged with the Featured Post tag. This is working perfectly.

However, if the front page is set to a static front page rather than Latest Posts, despite the box still being unchecked, the posts now appear in the post feed on the Blog page.

This seems to be by design: https://github.com/Automattic/jetpack/blob/86e4891c3c4f965c89e62347426f5bbeda415dc8/modules/theme-tools/featured-content.php#L275-L278

I don't see any immediately obvious reason why we would want to only exclude the posts on the Front Page but not on the Posts Page. On https://jetpack.com/support/featured-content/ we say that it's for the front page only, but this functionality can be useful for any Posts Page, not just the Front Page of a site, so I think we should remove the the code linked to above.

laurelfulford commented 8 years ago

Having the checkbox hide featured-content posts from the blog page - no matter whether the blog happens to be on the front page or not - would definitely be an improvement! It would fix many cases where there are duplicate posts under the Featured Content, simply because the user has assigned the posts page to a page other than the front.

The downside is that this still doesn't solve the problem for themes that display posts on a static page with a custom page template.

There's also the issue of custom post types - for example, Sketch allows users to tag portfolio projects as Featured Content. It's not possible to prevent those projects from displaying twice. You can see this issue currently on the demo - https://sketchdemo.wordpress.com - where "Fruit Pattern" is both in the FC slider, and in the portfolio grid beneath it.

Would it be possible to prevent posts from displaying twice only on the page that displays Featured Content? This seems more in line with how the checkbox currently works (except that it assumes Featured Content will only be on the front page).

Making the checkbox behave more like the label wording implies - i.e. hiding the posts from everywhere - is another route, but I think it could be confusing to have posts suddenly disappear from archives and search results, so we should probably avoid that option.

laurelfulford commented 7 years ago

Another report of this issue, from a user using the Dyad 2 theme.

User report: 767287-zen Original ticket: 4882-wpcom-themes

alaczek commented 6 years ago

Another report of this issue in Textbook theme: 4911-wpcom-themes

laurelfulford commented 6 years ago

Another report of this issue, using the Qua theme.

Theme ticket: 2317-wpcom-premium-themes Chat: 2161107-hc

Hat-tip @spncrb

alaczek commented 6 years ago

Another report: 1436-wpcom-premium-themes (Venture theme)

kathrynwp commented 6 years ago

Another report: 8069-wpcom

alaczek commented 6 years ago

Another report: 2437-wpcom-premium-themes (Port)

AtrumGeost commented 6 years ago

Another report, the user wanted to hide their featured posts on their "Posts Page" 6689036-hc

stale[bot] commented 5 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

stale[bot] commented 5 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

stale[bot] commented 4 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

lancewillett commented 4 years ago

Tracking a similar issue here: https://github.com/Automattic/wp-calypso/issues/28957

lancewillett commented 4 years ago

Pull request created in https://github.com/Automattic/jetpack/pull/15562 to fix this.