Infinite scroll: should support multiple wrapper classes

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.

https://jetpack.com/

Other

1.59k stars 799 forks source link

Infinite scroll: should support multiple wrapper classes #3659

Open lgladdy opened 8 years ago

lgladdy commented 8 years ago

At present, all CSS classes passed into infinite scroll go through a regex filter that strips out spaces, meaning you can only provide one class.

In the case of 'wrapper', it makes sense to allow multiple classes as many themes using CSS frameworks will need to use responsive classes on the content that's pulled in on scroll.

Taking a look at the places $css_pattern is used, there is no reason why we shouldn't just modify the $css_pattern to support spaces.

gravityrail commented 8 years ago

I updated this to target 4.4 as per the release on the associated PR

stale[bot] commented 6 years ago

This issue has been marked as stale. This happened because:

It has been inactive in the past 6 months.
It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.