search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.58k stars 800 forks source link

Image Guide remains paused after disable/re-enable feature in Boost Settings #36937

Open alinclamba opened 4 months ago

alinclamba commented 4 months ago

Impacted plugin

Boost

Quick summary

When a user pauses the Image Guide feature via the toolbar and then disables and re-enables it in the Jetpack Boost settings, the feature incorrectly retains its paused state. This is problematic, especially for users with multiple plugins occupying toolbar space, as they cannot unpause and regain use of the Image Guide due to this retention issue.

See screenshot below where a user has too many options in the toolbar so there's no room left for Image Guide to un-pause it:

image

This was reported in this ticket: 8050519-zd-a8c

Steps to reproduce

  1. Pause the Image Guide feature from the toolbar.
  2. Navigate to Jetpack → Settings → Boost and disable the Image Guide feature.
  3. Re-enable the Image Guide feature in the Boost settings.
  4. Observe that the Image Guide feature remains paused in the toolbar.

A clear and concise description of what you expected to happen.

The Image Guide feature should default back to an active state upon re-enabling in the Boost settings, allowing users to access it without issue.

What actually happened

No response

Impact

All

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

github-actions[bot] commented 4 months ago

Support References

This comment is automatically generated. Please do not edit it.

mrfoxtalbot commented 4 months ago

I can reproduce the issue on my testing site @alinclamba. Regarding this part:

especially for users with multiple plugins occupying toolbar space, as they cannot unpause and regain use of the Image Guide due to this retention issue.

You make a valid point but, if their toolbar is so crowded they cannot access the setting there, how were they able to turn it off in the first place? 🤔 Thanks!

alinclamba commented 4 months ago

@mrfoxtalbot thank you for checking this.

You make a valid point but, if their toolbar is so crowded they cannot access the setting there, how were they able to turn it off in the first place?

I think they the Image Guide feature, paused it, then installed other plugins later, and this caused the toolbar to get cluttered with other options. Eventually, they resolved it by temporarily deactivating all plugins except Boost, so that the Image Guide option would appear in the toolbar and they could unpause it.

Sometimes it's not ideal to ask users to deactivate their plugins, which is why I initially thought that deactivating the feature in the Boost settings and reactivating it would work, but the problem persisted even with reinstalling the Boost plugin (which the user did on their own initiative). That's why I'm wondering if we can make it so that once the option is deactivated, the paused/active status resets.

mrfoxtalbot commented 4 months ago

Thank you for the detailed explanation, @alinclamba. I think it makes perfect sense and I would leave this open as an enhancement.