Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 797 forks source link

Jetpack Dashboard fatal JS error with Scan #37366

Closed simison closed 6 months ago

simison commented 6 months ago

Impacted plugin

Jetpack

Quick summary

No response

Steps to reproduce

  1. Jetpack plugin active, no other plugins needed. I tried with Scan installed and active; I'm still seeing the error.
  2. Open Jetpack -> Dashboard (/wp-admin/admin.php?page=jetpack#/dashboard)
  3. After loading, the page breaks on JS error.

Rebuilding Jetpack with its dependencies doesn't fix the issue.

A clear and concise description of what you expected to happen.

No response

What actually happened

Some people see the error, some don't.

image

https://github.com/Automattic/jetpack/assets/87168/b1942492-ee65-44f9-a576-b8025d632dbd

Impact

Some (< 50%)

Available workarounds?

No and the platform is unusable

Platform (Simple and/or Atomic)

No response

Logs or notes

Firefox / Chrome

At the failing code:

https://github.com/Automattic/jetpack/blob/4424768ba86dbbbb42bdcd6af5d3c6dc6b6f7256/projects/plugins/jetpack/_inc/client/at-a-glance/scan.jsx#L391-L407

props is:

{
    "multisite": false,
    "siteAdminUrl": "https://simison.jurassic.tube/wp-admin/",
    "siteRawUrl": "simison.jurassic.tube",
    "isAtomicSite": false,
    "isOfflineMode": false,
    "scanStatus": null,
    "fetchingScanStatus": false,
    "isVaultPressInstalled": true,
    "fetchingVaultPressData": false,
    "vaultPressData": "N/A",
    "scanThreats": 0,
    "fetchingSiteData": false,
    "sitePlan": {
        "product_id": 2002,
        "product_slug": "jetpack_free",
        "product_name": "Jetpack Free",
        "product_name_short": "Free",
        "expired": false,
        "billing_period": "",
        "user_is_owner": false,
        "is_free": true,
        "license_key": "",
        "features": {
            "active": [
                "advanced-seo",
                "backups",
                "cdn",
                "search",
                "donations",
                "full-activity-log",
                "instant-search",
                "jetpack-dashboard",
                "priority_support",
                "real-time-backups",
                "recurring-payments",
                "republicize",
                "scan",
                "security-settings",
                "seo-preview-tools",
                "send-a-message",
                "simple-payments",
                "social-previews",
                "subscriber-unlimited-imports",
                "upload-audio-files",
                "upload-video-files",
                "whatsapp-button",
                "wordads",
                "social-image-auto-convert",
                "social-mastodon-connection",
                "social-instagram-connection",
                "social-multi-connections"
            ],
            "available": {
                "akismet": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "antispam": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "backups": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "backups-daily": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "calendly": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly"
                ],
                "cloudflare-analytics": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "cloudflare-cdn": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "core/audio": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "core/cover": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly"
                ],
                "core/video": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly"
                ],
                "full-activity-log": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "google-analytics": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "opentable": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly"
                ],
                "priority_support": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "scan": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "simple-payments": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "social-shares-1000": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "subscriber-unlimited-imports": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "support": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "vaultpress-automated-restores": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly"
                ],
                "vaultpress-backup-archive": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly"
                ],
                "vaultpress-backups": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "vaultpress-storage-space": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly"
                ],
                "video-hosting": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "videopress": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_personal",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_personal_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "videopress-1tb-storage": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "videopress/video": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly"
                ],
                "wordads": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "wordads-jetpack": [
                    "jetpack_premium",
                    "jetpack_business",
                    "jetpack_premium_monthly",
                    "jetpack_business_monthly",
                    "jetpack_security_daily",
                    "jetpack_security_daily_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "search": [
                    "jetpack_business",
                    "jetpack_business_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "google-my-business": [
                    "jetpack_business",
                    "jetpack_business_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "polldaddy": [
                    "jetpack_business",
                    "jetpack_business_monthly"
                ],
                "personal-themes": [
                    "jetpack_business",
                    "jetpack_business_monthly"
                ],
                "premium-themes": [
                    "jetpack_business",
                    "jetpack_business_monthly"
                ],
                "real-time-backups": [
                    "jetpack_business",
                    "jetpack_business_monthly",
                    "jetpack_security_realtime",
                    "jetpack_security_realtime_monthly",
                    "jetpack_complete",
                    "jetpack_complete_monthly",
                    "jetpack_security_t1_bi_yearly",
                    "jetpack_security_t1_yearly",
                    "jetpack_security_t1_monthly",
                    "jetpack_security_t2_yearly",
                    "jetpack_security_t2_monthly"
                ],
                "vaultpress-security-scanning": [
                    "jetpack_business",
                    "jetpack_business_monthly"
                ],
                "cloud-critical-css": [
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "image-cdn-liar": [
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "image-cdn-quality": [
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "image-size-analysis": [
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "instant-search": [
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "performance-history": [
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "social-enhanced-publishing": [
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ],
                "stats-paid": [
                    "jetpack_complete",
                    "jetpack_complete_monthly"
                ]
            }
        }
    },
    "planClass": "is-free-plan",
    "showBackups": true,
    "upgradeUrl": "https://simison.jurassic.tube/wp-admin/admin.php?page=my-jetpack#/add-scan",
    "hasConnectedOwner": true
}
liviopv commented 6 months ago

📌 REPRODUCTION RESULTS

📌 FINDINGS/SCREENSHOTS/VIDEO WordPress.com Atomic CleanShot 2024-05-14 at 11 40 41@2x

Jurrassic.Ninja after purchasing Scan CleanShot 2024-05-14 at 11 45 35@2x

WPCloud - Pressable CleanShot 2024-05-14 at 11 46 01@2x

📌 ACTIONS

📌 Message to Author @simison I wasn't able to reproduce it on any test site when visiting Jetpack > Dashboard with Scan active. Did I miss anything? Is there any action that is supposed to trigger the error?

I'm leaving for Vulcan to triage it as well, but I'm switching the priority to Normal for now.

simison commented 6 months ago

Yeah, I haven't found others who could've reproduce either so this might be my local setup issue, or requires very specific steps to enable/disable different features or plugins.

Testing now, the dashboard is working, so closing.