Port over icons from Jetpack's "Social Logos" feature

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.

https://jetpack.com/

Other

1.58k stars 800 forks source link

Port over icons from Jetpack's "Social Logos" feature #37557

Open rickcurran opened 5 years ago

rickcurran commented 5 years ago

The Jetpack plugin uses "Social Logos" as a source of icons for features like its "Social Icons Widget", however, there are icons that have been added to Jetpack that are not in the main Social Logos repo (and perhaps vice-versa).

The original process was meant to be that new icons were added here in the Social Logos repo first and then pulled into Jetpack but somehow at times that process hasn't happened, so now they are out of sync.

To try and get these back in sync the two should be cross-referenced so that all icons exist in the "Social Logos".

davewhitley commented 3 years ago

Can we have a list of the icons that we are missing?

cc @sdixon194

sdixon194 commented 3 years ago

@davewhitley sure thing! Looks like quite a few.

Here is what's included in Jetpack that's not in the repo:

500px
Apple
iTunes
bandcamp
Deviantart
Discord
Digg
Etsy
Goodreads
Meetup
Ravelry
Slideshare
Snapchat
Soundcloud
Stackoverflow
VK
Yelp

Here is what's included in the repo but not in Jetpack:

Blogger
Eventbrite
Ghost
Polldaddy
Whatsapp
WooCommerce
Xanga

I can work on getting the latter added to Jetpack so we have parity there.

davewhitley commented 3 years ago

Thanks for the list! You can ignore the polldaddy one for now https://github.com/Automattic/jetpack/issues/37556

sdixon194 commented 3 years ago

Sounds good! PR here:

https://github.com/Automattic/jetpack/pull/18563