Admin dashboard: button style issues (stats, footer) - Githubissues

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.

https://jetpack.com/

Other

1.59k stars 797 forks source link

Admin dashboard: button style issues (stats, footer) #37616

Open jeherve opened 6 months ago

jeherve commented 6 months ago

Some of the button styles seem to cause layout oddities in the Jetpack dashboard. Here are some examples:

When Stats are disabled, go to Jetpack > Settings and search for stats

Screenshot 2024-05-29 at 11 25 32

At the bottom of the Settings screen, click on the menu items; when focused, a button pill appears:

https://github.com/Automattic/jetpack/assets/426388/2359a216-dfd9-4e17-8bee-3ba97c867cf3

We may have to update the styles there to avoid such issues.

https://github.com/Automattic/jetpack/blob/54d3e8686c8bc7451708547d6900e27885532ca4/projects/plugins/jetpack/_inc/client/traffic/site-stats.jsx#L210-L212 https://github.com/Automattic/jetpack/blob/14361cdba8f1d113a5d210c50c1a561726fca7c5/projects/plugins/jetpack/_inc/client/components/button/style.scss#L6-L10 https://github.com/Automattic/jetpack/blob/4b1333c312452e6a521c865f4d4bf79ced790efa/projects/js-packages/components/components/jetpack-footer/index.tsx#L139-L156 https://github.com/Automattic/jetpack/blob/4b1333c312452e6a521c865f4d4bf79ced790efa/projects/js-packages/components/components/jetpack-footer/style.scss#L27-L32

github-actions[bot] commented 7 hours ago

This issue has been marked as stale. This happened because:

It has been inactive for the past 6 months.
It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `[Type] Janitorial`, `Good For Community`, `[Type] Good First Bug`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.