Open alshakero opened 5 days ago
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
move/help-center
branch.
jetpack-mu-wpcom
changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
to your wp-config.php
file.To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin move/help-center
Interested in more tips and information?
jetpack rsync
command to sync your changes to a WoA dev blog.Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.
Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.
Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.
The static analysis is failing. But the cause of this is from another PR
Testing in progress:
Simple site:
Atomic site:
Disconnected Atomic site:
Proposed changes:
This enqueues one of four bundles from
widgets.wp.com
. It chooses the bundle based on the context:help-center-gutenberg.min.js
: for GB editor in a connected site.help-center-wp-admin
: for wp-admin in a connected site.help-center-wp-admin-disconnected.js
: for wp-admin in a disconnected site.help-center-gutenberg-disconnected
: for GB editor in a disconnected site.It also adds 12 new end points that proxy Atomic requests to wpcom. These endpoints are copied from ETK almost verbatim and have been battle tested for months/years.
Other information:
Jetpack product discussion
There have been many discussions around moving the Help Center to Jetpack. But the most recent one is: p1718801409878749-slack-C0347E545HR
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Simple sites
projects/packages/jetpack-mu-wpcom
.pnpm run build-production-js && jetpack rsync mu-wpcom-plugin wpcom-sandbox:~/public_html/wp-content/mu-plugins/jetpack-mu-wpcom-plugin/sun
help-center
bundle in the Network tab of the DevTools.Connected Atomic site
projects/packages/jetpack-mu-wpcom
.jetpack-mu-wpcom
with your WoA site using this commandjetpack rsync mu-wpcom-plugin wpcom-atomic:htdocs/wp-content/plugins/jetpack-mu-wpcom-plugin-dev
. Assuming you have an ssh host pointing to a WoA site.~/htdocs/wp-config.php
and adddefine( 'JETPACK_AUTOLOAD_DEV', true );
.~/htdocs/wp-config.php
and adddefine( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
help-center
bundle in the Network tab of the DevTools.Disconnected Atomic site
/_cli
and runningjetpack disconnect blog
.