Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.57k stars 793 forks source link

WordPress.com: Add the Help Center App ✨ #38093

Open alshakero opened 5 days ago

alshakero commented 5 days ago

Proposed changes:

This enqueues one of four bundles from widgets.wp.com. It chooses the bundle based on the context:

It also adds 12 new end points that proxy Atomic requests to wpcom. These endpoints are copied from ETK almost verbatim and have been battle tested for months/years.

Other information:

Jetpack product discussion

There have been many discussions around moving the Help Center to Jetpack. But the most recent one is: p1718801409878749-slack-C0347E545HR

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Simple sites

  1. cd into projects/packages/jetpack-mu-wpcom.
  2. Sync using pnpm run build-production-js && jetpack rsync mu-wpcom-plugin wpcom-sandbox:~/public_html/wp-content/mu-plugins/jetpack-mu-wpcom-plugin/sun
  3. Go to the editor on a sandboxed site and smoke test the Help Center.
  4. Go to /wp-admin on a sandboxed site and smoke test the Help Center.
  5. Verify that it's loaded from Jetpack by checking the path of the help-center bundle in the Network tab of the DevTools.

Connected Atomic site

  1. cd into projects/packages/jetpack-mu-wpcom.
  2. Sync jetpack-mu-wpcom with your WoA site using this command jetpack rsync mu-wpcom-plugin wpcom-atomic:htdocs/wp-content/plugins/jetpack-mu-wpcom-plugin-dev. Assuming you have an ssh host pointing to a WoA site.
  3. Important: Edit ~/htdocs/wp-config.php and add define( 'JETPACK_AUTOLOAD_DEV', true );.
  4. Important: Edit ~/htdocs/wp-config.php and add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
  5. Go to the editor and smoke test the Help Center.
  6. Go to /wp-admin and smoke test the Help Center.
  7. Verify that it's loaded from Jetpack by checking the path of the help-center bundle in the Network tab of the DevTools.

Disconnected Atomic site

  1. Disconnect a JP site by going to /_cli and running jetpack disconnect blog.
  2. Go to /wp-admin/post-new.php.
  3. Click the Help Center.
  4. It should take you to wp.com/help.
  5. Repeat in wp-admin.
  6. It should take you to wp.com/help.
  7. Reconnect your site by going to https://jptools.wordpress.com/debug/?url=YOUR_SITE and click "Restore User Connection".
github-actions[bot] commented 5 days ago

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

Interested in more tips and information?

github-actions[bot] commented 5 days ago

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Mu Wpcom plugin:

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

heavyweight commented 21 hours ago

The static analysis is failing. But the cause of this is from another PR

Screenshot 2024-07-02 at 15 24 12
agrullon95 commented 19 hours ago

Testing in progress:

Simple site:

Atomic site:

Disconnected Atomic site: