Closed anomiex closed 1 day ago
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.
Inspect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
update/replace-eslint-plugin-svelte3
branch.
jetpack-mu-wpcom
changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
to your wp-config.php
file.To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/replace-eslint-plugin-svelte3
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/replace-eslint-plugin-svelte3
Interested in more tips and information?
jetpack rsync
command to sync your changes to a WoA dev blog.
Proposed changes:
The npm package
eslint-plugin-svelte3
is deprecated in favor ofeslint-plugin-svelte
. The updated config appears to also requiresvelte-eslint-parser
.Then fix some new lints it complains about:
Popup.svelte
are no longer used (since #31145).@html
being unsafe. Our one use was easy to convert to{#if}
.Other information:
Jetpack product discussion
None
Does this pull request change what data or activity we track or use?
No
Testing instructions: