Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Social: Add 'Save to media library' button for SIG image #38106

Closed manzoorwanijk closed 3 months ago

manzoorwanijk commented 3 months ago

Now that we're changing the logic around attached media, it's not possible to upload the SIG created image with the social post. As a work around, and a feature that could be useful for other reasons, it would be good to add a 'Save to media library' button, either in the sidebar, or in the SIG options modal, or both. This could then be selected as the attached media.

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

image Screenshot 2024-06-28 at 11 08 47 AM

https://github.com/Automattic/jetpack/assets/18226415/4cb4e5d7-5121-4f6a-bf33-d49438681cd2

github-actions[bot] commented 3 months ago

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

github-actions[bot] commented 3 months ago

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

Interested in more tips and information?

manzoorwanijk commented 3 months ago

Moved settings button to start

image