Closed sergeymitr closed 4 days ago
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/google-analytics-missing-key
branch.
To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/google-analytics-missing-key
Interested in more tips and information?
jetpack rsync
command to sync your changes to a WoA dev blog.
Reported in https://github.com/Automattic/vulcan/issues/313#issuecomment-2196524284.
Proposed changes:
Other information:
Jetpack product discussion
pfwV0U-4g-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
jetpack_wga
option if exists (wp option delete jetpack_wga
).debug.log
, confirm there's noUndefined array key "is_active"
PHP warning.