Closed tbradsha closed 4 days ago
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.
I noticed some historical data that was missing from the current changelog. I merged the two changelog files and backfilled the old changelog entries
If I recall well, we decided to keep the old changelog in one file and the new one in another one. But I remember why we did it.
I don't recall why we did it.
- The v4-v5 logs were probably not added to the new file because it was a different format. This PR standardizes it.
- The pre-v4 logs were removed in v4, likely because it was in
readme.txt
and was just getting too long. Now that we have a separate changelog file, there's no reason to not have it all. This PR adds a standardized version of the old entries.
probably not added to the new file because it was a different format
That is 👍
While updating the CRM sites to PHP 8.2 I tested the API Connector and noticed it was retrieving the CRM version as 6.4.2 instead of 6.4.3 because a version bump was missed in the last release. This PR fixes it.
Also, while retiring some old sites I noticed some historical data that was missing from the current changelog. I merged the two changelog files and backfilled the old changelog entries. I fixed a few minor typos in the process.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Make sure each entry has a consistent header entry and date format.