Closed monsieur-z closed 4 days ago
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.
Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.
Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
fix/use-jetpack-plugin-custom-css-for-atomic
branch.
jetpack-mu-wpcom
changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
to your wp-config.php
file.To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/use-jetpack-plugin-custom-css-for-atomic
Interested in more tips and information?
jetpack rsync
command to sync your changes to a WoA dev blog.
Proposed changes:
https://github.com/Automattic/jetpack/pull/37794 caused the wpcomsh plugin to throw the exception:
PHP Fatal error: Cannot redeclare jetpack_register_css_preprocessors()
.This PR prevents the exception from being thrown by temporarily disabling the loading of the Custom CSS for atomic sites in the
jetpack-mu-wpcom
package (the Custom CSS will still be available in the Jetpack plugin for now). See conversation linked below for more details.Other information:
Jetpack product discussion
p1719591775246119-slack-C05PV073SG3
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Spin up a WoA developer site
Install and activate a classic theme, such as Twenty-Eleven
From
/wp-admin/admin.php?page=jetpack_modules
, activate the Custom CSS moduleInstall the Jetpack Beta Tester plugin
In WPadmin, go to Jetpack > Beta Tester
Select this branch for the WordPress.com Features
In the admin, visit Appearance > Additional CSS
Make sure you see the options above and that you can write additional CSS