Jetpack AI Image: add button entrypoint on the image block

lhkowalski commented 4 days ago

Fixes #38122.

Proposed changes:

Add a "Generate with AI" button on the image block, gallery block and slideshow block when the beta flag is enabled (same as the media source menu)
The button will launch the General Purpose Image Generator and execute all the actions setting the correct placement (a new value, block-placeholder-button)
Make the tool works when the block demands multiple image selection, but keep inserting just one image; this will fix things for the gallery and slideshow blocks

Other information:

[ ] Have you written new tests for your changes, if applicable?
[ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
[ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Enable beta extensions, go to the block editor and add an image block
Confirm you can see the "Generate with AI" button:

Confirm the general purpose image tool will show up when you click the button
Confirm you can request an image and then use it on the block by clicking "Insert image"
Do the same for the following blocks:
- Slideshow
- Gallery

Confirm the following blocks will not show the button:
- Cover
- Media & Text
- Image Compare
- Story
- Tiled Gallery
- these blocks are extended by the same code so they could show the other media sources the code adds, but I opted to limit the usage on them to focus on the core ones
Confirm the button will not show up when beta extensions are disabled

github-actions[bot] commented 4 days ago

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/jetpack-ai-image-image-block-entrypoint branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/jetpack-ai-image-image-block-entrypoint

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] commented 4 days ago

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

:white_check_mark: Include a description of your PR changes.
:white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
:white_check_mark: Add testing instructions.
:white_check_mark: Specify whether this PR includes any changes to data or privacy.
:white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen daily.
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on July 29, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

CGastrell commented 1 day ago

LGTM, I'm freshly coming back so I'll leave Douglas to give the final tick.

With BETA enabled I could see/use the button on Image, Gallery and Slideshow. Button would not show on any of the other listed blocks.

Without BETA I could not find the button anywhere.

Generated images inserted fine. Editing the Gallery or Slideshow won't give you the AI generator, but I think that's by design (no UI place for it, only upload or media gallery)

Automattic / jetpack