Newsletters: site icon doesn't work if it's .ico

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.

https://jetpack.com/

Other

1.59k stars 798 forks source link

Newsletters: site icon doesn't work if it's .ico #38455

Open simison opened 2 months ago

simison commented 2 months ago

Users might upload the site logo to their site in .ico format; this doesn't load in the emails via our CDN.

Working file path: mimarsozluk.com.tr/wp-content/uploads/2024/01/favicon.ico

Non working CDN path: i0.wp.com/mimarsozluk.com.tr/wp-content/uploads/2024/01/favicon.ico

Results in:

Solution ideas:

Skip CDN for .ico?
Resolve to default logo when detecting non-supported file format
Support .ico at our CDN

8507734-zd-a8c

github-actions[bot] commented 2 months ago

Support References

This comment is automatically generated. Please do not edit it.

[ ] 8507734-zen

simison commented 3 weeks ago

Might be the case with svg files too. Skipping CDN for svg files wouldn't work as services like Gmail won't show SVG files in emails anyway.