Subscribe block: missing margin above inspector notice

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.

https://jetpack.com/

Other

1.59k stars 799 forks source link

Subscribe block: missing margin above inspector notice #39873

Open jsnajdr opened 3 days ago

jsnajdr commented 3 days ago

If you insert the Subscribe block, its inspector controls include a notice, which has a missing top margin:

@jeherve already fixed this once in #29631, but the fix relies on the .components-tab-panel__tab-content class name. But that class name is no longer there in latest Gutenberg, the styles have been refactored to be fully Emotion-al. And the bug is back.

FYI @ciampo @mirka for awareness about this compat issue.

ciampo commented 3 days ago

Thank you for the ping! Classnames are not part of the public APIs of a component, and therefore relying on them can cause regressions when the implementation details change.

The correct fix would be to add a custom class name to the tabpanel, that jetpack can use to add styles. Or add styles directly to the "15 readers are subscribed" UI?