Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 798 forks source link

Subscribe Block: cannot edit submit button label #40072

Open jeherve opened 1 day ago

jeherve commented 1 day ago

Impacted plugin

Jetpack

Quick summary

When editing an existing Subscribe block in the site editor, we can only edit the submit button text one letter at a time.

Steps to reproduce

  1. Start with a site that's connected to WordPress.com.
  2. Go to Jetpack > Settings > Newsletter and enable Subscriptions.
  3. Go to Appearance > Editor and add the Subscribe block to one of your templates.
  4. Click on the subscribe block and check the block sidebar settings.
  5. There, open the "Settings" panel, and click to update the "submit button label"

A clear and concise description of what you expected to happen.

I would expect to be able to delete and then type in some next text.

What actually happened

When tying some text, only one letter is added to the field, and then it goes out of focus. We must click on the field again to enter another single letter.

Impact

All

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Self-hosted

Logs or notes

No response

lezama commented 19 hours ago

When tying some text, only one letter is added to the field, and then it goes out of focus. We must click on the field again to enter another single letter.

I tried both locally and using jurassic.ninja and I couldn't repro! Any js console errors?

simison commented 11 hours ago

Knowing Gutenberg/WP version would be helpful.

jeherve commented 8 hours ago

I am able to reproduce with the latest version of WordPress, latest Jetpack Stable, and no Gutenberg:

https://github.com/user-attachments/assets/91f1608e-87fa-4d99-9c42-e26a0415d78d

lezama commented 6 hours ago

hmm, maybe it is a browser thing? Same versions, no plugins and no errors for me in Chrome

https://github.com/user-attachments/assets/81fa6e37-0cde-4f44-981c-353bd10943ab

jeherve commented 3 hours ago

Interesting! I was using Firefox (133.0b2 (aarch64)) in that test. I'm not able to reproduce in Chrome either.