Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 797 forks source link

Boost: Update the cornerstone pages UI #40165

Closed donnchawp closed 2 days ago

donnchawp commented 1 week ago

Resolves #40139

Update the cornerstone UI so it's a panel, instead of a settings form.

See pc9hqz-3cJ-p2#comment-2292

Proposed changes:

*

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions[bot] commented 1 week ago

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Boost plugin:

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

dilirity commented 3 days ago

@haqadn just noticed the UI not aligned.

What browser is this?

For me it's aligned in Chrome

image

haqadn commented 3 days ago

@haqadn just noticed the UI not aligned.

What browser is this?

For me it's aligned in Chrome

image

I'm also using chrome. I found that line height of 1.5 works better with vertical alignment of text. @dilirity

donnchawp commented 2 days ago

Cherry picked for 3.6.0 beta 2 ca9cd48168a8edeafa336cc5fa2f4d8a6e8caa4c