Closed elliottprogrammer closed 4 days ago
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance!
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/my-jetpack-atomic-remove-connection
branch.
To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/my-jetpack-atomic-remove-connection
Interested in more tips and information?
jetpack rsync
command to sync your changes to a WoA dev blog.
This PR removes the "Connection" status & management section in My Jetpack for Atomic sites.
Jetpack should always be Active on WoA sites and users should not be able or allowed to manually "disconnect" their Jetpack connection. Therefore, the "Connection" section in My Jetpack is not needed and not wanted on WoA sites because it may cause user confusion and possibly invite and allow users to disconnect their Jetpack connection on their Atomic site. Removing the "Connection" section for WoA sites will prevent users from manually disconnecting their site.
P2 post & discussion: pf5801-1d5-p2
Fixes https://github.com/Automattic/jetpack-marketing/issues/1078
Proposed changes:
isAtomic
.Other information:
Jetpack product discussion
pf5801-1d5-p2
Does this pull request change what data or activity we track or use?
Testing instructions:
Prerequisite:
Instructions:
update/my-jetpack-atomic-remove-connection
branch.Screenshot: