Codesniffer: remove PHP 7.0 and 7.1 support

tbradsha commented 1 week ago

As the title says, it removes PHP 7.0 and 7.1 support, and updates the tests accordingly.

We should add PHP 8+ tests, but that will probably be after updating to PHPUnit 10+.

Other information:

[ ] Have you written new tests for your changes, if applicable?
[ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
[ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Verify CI is happy, or run tests manually: composer test-php

github-actions[bot] commented 1 week ago

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

:white_check_mark: Include a description of your PR changes.
:white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
:white_check_mark: Add testing instructions.
:white_check_mark: Specify whether this PR includes any changes to data or privacy.
:white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

tbradsha commented 1 week ago

Also alphabetical ordering FTW

These are auto-generated files. That said, I wonder why the order is different...I suspect the default on my machine vs. Brad's is different. 🤔

Edit: I tried running it after using export LC_COLLATE=C but there were no changes when I did so. @zinigor @anomiex can you confirm the generated files on your end result in no changes in the files that are committed in this branch? Ideally generation would be consistent.

anomiex commented 1 week ago

We should add PHP 8+ tests, but that will probably be after updating to PHPUnit 10+.

It's not PHPUnit that needs updating, it's phpcompatibility/php-compatibility. I'm not sure if PHP 8.0 checks still aren't finished or if the v10 release is now waiting on 8.4 checks, but either way there's no release to update to. 🙁 https://xkcd.com/2347/

Automattic / jetpack