Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 797 forks source link

Connection: allow using application password for site registration #40233

Closed sergeymitr closed 3 days ago

sergeymitr commented 3 days ago

Proposed changes:

Other information:

Jetpack product discussion

https://github.com/Automattic/vulcan/issues/555

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  1. Disconnect Jetpack.
  2. Run the cURL command to register the site with WPCOM:
    curl 'https://example.com/index.php?rest_route=/jetpack/v4/connection/register' -X POST -H 'Content-Type: application/json' --data-raw '{"from":"jetpack-app","plugin_slug":"jetpack"}'

    Confirm you get the invalid_user_permission_jetpack_connect error along with error message and 401 status code.

  3. User "Jetpack Debug" plugin's "REST API Tester" to send a REST request:
    • route: jetpack/v4/connection/register
    • method: POST
    • body: {"from":"jetpack-app","plugin_slug":"jetpack"}
  4. Confirm you receive the 403 "invalid_nonce" error.
  5. Go to "Users -> Profile" and create an application password.
  6. Run the same cURL command with additional -u username:app_password in the end.
  7. Confirm it responded with an authorization URL, and the site is now connected in site-only mode.
github-actions[bot] commented 3 days ago

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

Interested in more tips and information?

github-actions[bot] commented 3 days ago

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!