Closed jeherve closed 6 days ago
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance!
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
add/charts-js-package
branch.
jetpack-mu-wpcom
changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
to your wp-config.php
file.To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/charts-js-package
bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/charts-js-package
Interested in more tips and information?
jetpack rsync
command to sync your changes to a WoA dev blog.@Automattic/jetpack-garage I had to push a few additional changes after running the generate
command. I think it may be worth updating generate
so those are created right off the bat?
Proposed changes:
This package can then be used by multiple teams to handle charts within Automattic properties.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Not much to test yet. Is CI happy?