codesniffer: Add Jetpack-Compat-84 ruleset

anomiex commented 2 days ago

Proposed changes:

Like the other Jetpack-Compat-* rulesets, this one disables rules that trigger with PHP 7.2 but not 8.4.

Other information:

[ ] Have you written new tests for your changes, if applicable?
[ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
[ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None worth linking.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

CI happy?

github-actions[bot] commented 2 days ago

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

:white_check_mark: Include a description of your PR changes.
:white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
:white_check_mark: Add testing instructions.
:white_check_mark: Specify whether this PR includes any changes to data or privacy.
:white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

anomiex commented 2 days ago

They're both correct, just worded differently. In the readme you need to read the paragraphs above the list to find the reference to 7.2.

The only way I can think of for "Standard to disable PHPCompatibility rules that trigger with 7.2 but not 8.4." to not be accurate is if there's a rule that triggers for 7.2 and 8.4 but not for some version in between, which seems unlikely.

Automattic / jetpack