Repo Gardening: only make board changes when issue is on the board

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.

Other

1.59k stars 798 forks source link

Proposed changes:

Right now, we only want to add an issue to the One Board when it's a bug. In this case, for non-bugs, we don't want to try to update the issue's properties on the board whe they haven't been added to the board in the first place.

This should fix errors like this one:

main: Task triageIssues failed with error: GraphqlResponseError: Request failed due to following response errors: - Could not resolve to a node with the global id of ''

Other information:

[ ] Have you written new tests for your changes, if applicable?

[ ] Have you checked the E2E test CI results, and verified that your changes do not break them?

[ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Testing instructions:

This can only be tested on a fork. Here is an example of an issue that will not attempted to be triaged to the project board, generating no errors: https://github.com/jeherve/jetpack/issues/177

And one that will be added to the board, and the different automations will be triggered: https://github.com/jeherve/jetpack/issues/178

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

:white_check_mark: Include a description of your PR changes.
:white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
:white_check_mark: Add testing instructions.
:white_check_mark: Specify whether this PR includes any changes to data or privacy.
:white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Automattic / jetpack