CRM: Fix PHP error (and logic) on dashboard Recent Activity avatar

[tbradsha]

This makes sure the correct Gravatar URL is used for the dashboard's Recent Activity section.

Proposed changes:

I spotted this when clicking through a new site:

PHP Deprecated:  hash(): Passing null to parameter #2 ($data) of type string is deprecated in /srv/htdocs/wp-content/plugins/zero-bs-crm-dev/includes/ZeroBSCRM.GeneralFuncs.php on line 704

Digging around, I realized that the Recent Activity avatar was grabbing the gravatar of the contact ID that matches the WP ID that made the change. In other words, if WPID 1 (the admin) makes a change, it'll show the gravatar of Contact ID 1 (an arbitrary contact.

In other words:

• If the contact has an email, the gravatar will be wrong.
• If the contact has no email, it'll throw up the PHP notice.

I adjusted the logic to correctly generate gravatar URL for the WP user instead. If the WP user no longer exists, the image won't be rendered.

Other information:

• [ ] Have you written new tests for your changes, if applicable?
• [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
• [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

In a new site:

1. Set your user email to your actual email if it isn't already: /wp-admin/profile.php
2. Create a contact without an email (contact ID 1).
3. Go to the dashboard: /wp-admin/admin.php?page=zerobscrm-dash
4. Add a valid email to the contact (one that has an associated gravatar).
5. Go to the dashboard: /wp-admin/admin.php?page=zerobscrm-dash

In trunk, step 2 will generate a PHP notice (for each item in the Recent Activity section) and step 4 will show the contact's gravatar instead of the WP user's gravatar.

In the fix/crm/php_error_on_dash branch, the correct gravatar will show.

[github-actions[bot]]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• :white_check_mark: Include a description of your PR changes.
  
• :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• :white_check_mark: Add testing instructions.
  
• :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  
• :white_check_mark: Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!