Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 799 forks source link

Add/bundles to recommendations #40281

Closed CodeyGuyDylan closed 18 hours ago

CodeyGuyDylan commented 1 day ago

Proposed changes:

Other information:

Jetpack product discussion

P2: pbNhbs-bxX-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Checkout this branch via the Jetpack Beta plugin or your local dev environment
  2. Make sure your JN site has access to your sandbox
  3. Enable your sandbox on your testing site
  4. Checkout the following diff on your sandbox: D166839-code
  5. Go to My Jetpack and fill out the welcome banner survey and check all possible options so you can see Jetpack Complete image
  6. Ensure you see the Jetpack Complete recommendation. Make sure the "Purchase" button goes to checkout with Complete in the cart image
  7. Click on "Learn More" to see the new Complete interstitial. Make sure the interstitial works correctly by testing the CTA and ensuring it goes to checkout with Complete in the cart. image image
  8. Go back to My Jetpack and redo the recommendation survey. This time select Protect my site only. This should ensure you see the Security card. Test the same things you did with Complete with the interstitial and the card itself image image
  9. Go back to My Jetpack one more time and redo the survey again. This time, select only Grow my audience. Test this the same way you tested the last two bundles image image
  10. You've now tested all the new interstitials and recommendation cards. Now go to /wp-admin/admin.php?page=my-jetpack#/add-social and ensure that the bundle upsells still look like they used to and should image
  11. Lastly, we'll test the intro discount eligibility on the cards. Purchase any plan that you see in your recommendations on the site. For this example, I'll use Protect.
  12. After purchasing protect go remove it from your site via wordpress.com/me/purchases or the Store Admin
  13. Go back to My Jetpack and ensure you no longer see the intro discount on the card image
github-actions[bot] commented 1 day ago

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

Interested in more tips and information?

github-actions[bot] commented 1 day ago

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!