Open simison opened 1 day ago
Thank you for your PR!
When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:
The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.
Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance!
Jetpack plugin:
The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/likes-hide-avatars
branch.
To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/likes-hide-avatars
Interested in more tips and information?
jetpack rsync
command to sync your changes to a WoA dev blog.This is also contingent on the upstream phab diff D165404 merging to wpcom.
I feel I'm missing a step testing-wise for Jetpack self-hosted sites. I've got a sandboxed JN site, applied the diff, also added widgets.wp.com to my hosts file.
I can 'like' the post / page via the like block and see no avatar (yet it shows as liked). However the toggle state in the editor won't change, though the initial toggle click (followed by pressing save) does allow me to see my avatar when clicking like on the front-end now.
However the toggle state in the editor won't change
I'm having the same issue, and I don't get what's missing. 🤔 My local Jetpack isn't working now so having a bit hard time to develop, but I'll get this going and can ping when it's no longer in progress.
Related to https://github.com/Automattic/jetpack/pull/40276
Depends on D165404-code
Proposed changes:
This is backawards compatible as old blocks won't have setting, and in Gutenberg "default" value means no attribute is stored in block markup. Hence no deprecation transforms needed.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: