Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 799 forks source link

Likes block: allow hiding avatars #40282

Open simison opened 1 day ago

simison commented 1 day ago

Related to https://github.com/Automattic/jetpack/pull/40276

Depends on D165404-code

Proposed changes:

This is backawards compatible as old blocks won't have setting, and in Gutenberg "default" value means no attribute is stored in block markup. Hence no deprecation transforms needed.

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions[bot] commented 1 day ago

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] commented 1 day ago

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

Interested in more tips and information?

georgestephanis commented 1 day ago

This is also contingent on the upstream phab diff D165404 merging to wpcom.

coder-karen commented 1 day ago

I feel I'm missing a step testing-wise for Jetpack self-hosted sites. I've got a sandboxed JN site, applied the diff, also added widgets.wp.com to my hosts file.

I can 'like' the post / page via the like block and see no avatar (yet it shows as liked). However the toggle state in the editor won't change, though the initial toggle click (followed by pressing save) does allow me to see my avatar when clicking like on the front-end now.

simison commented 1 day ago

However the toggle state in the editor won't change

I'm having the same issue, and I don't get what's missing. 🤔 My local Jetpack isn't working now so having a bit hard time to develop, but I'll get this going and can ping when it's no longer in progress.