search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 799 forks source link

Shortcode: Polldaddy JS 404 #4032

Closed kraftbj closed 5 years ago

kraftbj commented 8 years ago

When using an Infinite Scroll enabled theme with the PD shortcode, a 404 for modules/shortcode/js/polldaddy-shortcode.js is seen in the console.

690c9baae8046f448f8b05b242372cdac694a882 seemed to add reference to the file, but didn't include it.

oskosk commented 7 years ago

Closing as this is no longer an issue. See gif below

JS file loaded properly in the console

polldaddyworking

kraftbj commented 7 years ago

The file referenced ( https://github.com/Automattic/jetpack/blob/master/modules/shortcodes/polldaddy.php#L306 ) is still not present and still causing a 404.

Steps to reproduce:

  1. Twenty Fifteen, ensure IS is set to load on scroll.
  2. Add in a post that would appear after the scroll (not sure this is required, but what I did).
  3. In the post, add a poll using the shortcode like [polldaddy poll="7721710"]
  4. Console: screen shot 2017-10-23 at 17 34 28
oskosk commented 7 years ago

Alright, thanks for the details @kraftbj. Will re-check. Thought I was testing the same conditions. Sorry for having closed it!

designsimply commented 6 years ago

Tested and confirmed using the testing steps provided.

screen shot 2018-04-05 at thu apr 5 10 37 06 pm Seen at https://design5279.wordpress.com/page/2/ using Firefox 59.0.2 on macOS 10.13.3.

The console error in Firefox says:

TypeError: _$(...) is null PDV_go7721710 https://static.polldaddy.com/p/7721710.js:81:13774 <anonymous> https://static.polldaddy.com/p/7721710.js:81:17192

stale[bot] commented 5 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

stale[bot] commented 5 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

jeherve commented 5 years ago

This was fixed in #11814