search

Automattic / jetpack

Security, performance, marketing, and design tools — Jetpack is made by WordPress experts to make WP sites safer and faster, and help you grow your traffic.
https://jetpack.com/
Other
1.59k stars 799 forks source link

Contact Form: Keyboard navigation fails on "Email Notifications" tab #663

Closed kraftbj closed 6 years ago

kraftbj commented 10 years ago

To duplicate:

  1. Add a new contact form via the modal button in the post editor.
  2. Choose the second tab at the top, E-Mail Notifications
  3. Change/add a custom notification e-mail address or subject.
  4. Press Enter to submit the form.

Expected: It accepts the data from that tab, returning you to the Form Builder tab.

Actual: It submits the Form Builder form, adding the shortcode to the post editor. Since the E-Mail Notifications form was never submitted, the e-mail address/subject changes are lost.

rase- commented 10 years ago

Hmm. Not sure if I would expect to go back to the form builder, since the UI is tabbed. But I would definitely expect to have the information saved in the shortcode.

rase- commented 10 years ago

When pressing enter while editing a field, what actually happens, is the field name being edited is updated to the form, so that even if you don't click Save this field before adding the form, the correct value will be stored in the shortcode.

We would probably want to have consistent functionality in both editing a form field, and when editing fields in the email notification tab. Thoughts on whether the current handling is good, or if we should handle enter differently? Also, would you agree that consistency would be good?

rase- commented 10 years ago

The "expected" as described by @kraftbj would be better I think, than just updating the field, since this is what you many times expect of forms. It would be nice to have this as the consistent behaviour.

kraftbj commented 10 years ago

Throwing out an alternative, instead of a tab, have a drop down "Advanced Options" that are all part of the same form. They're only hidden or not from view by toggling Advanced Options (or E-Mail Notifications) or whatever language.

stale[bot] commented 6 years ago

This issue has been marked as stale. This happened because:

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

jeherve commented 6 years ago

Closing this for now because of the lack of activity on this. The contact form builder has also been refreshed and does not work the same way anymore.

We can always reopen in the future if needed.